Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable AMICI_DLL_DIRS to control DLL directories on Windows #1637

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 12, 2022

Since Python3.8, external DLL directories need to be added via os.add_dll_directory.

This change provides the AMICI_DLL_DIRS environment variable as an alternative way to specify these directories.

Also, upgrades OpenBLAS to 0.3.19 and runs Windows tests on Python 3.8.

… Windows

Since Python3.8, external DLL directories need to be added via os.add_dll_directory.

This change provides the AMICI_DLL_DIRS environment variable as an alternative way to specify these directories.
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1637 (9a13ec7) into develop (c15bf1a) will decrease coverage by 4.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1637      +/-   ##
===========================================
- Coverage    78.86%   74.13%   -4.74%     
===========================================
  Files           69       25      -44     
  Lines        10713     3518    -7195     
===========================================
- Hits          8449     2608    -5841     
+ Misses        2264      910    -1354     
Flag Coverage Δ
cpp ?
petab 66.68% <ø> (ø)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/pandas.py 11.62% <0.00%> (-86.63%) ⬇️
python/amici/testing.py 0.00% <0.00%> (-50.00%) ⬇️
python/amici/import_utils.py 47.32% <0.00%> (-39.70%) ⬇️
python/amici/pysb_import.py 57.03% <0.00%> (-36.83%) ⬇️
python/amici/numpy.py 65.21% <0.00%> (-17.40%) ⬇️
python/amici/__init__.py 76.08% <0.00%> (-16.31%) ⬇️
python/amici/setuptools.py 50.00% <0.00%> (-7.70%) ⬇️
python/amici/parameter_mapping.py 69.56% <0.00%> (-6.09%) ⬇️
python/amici/ode_export.py 88.25% <0.00%> (-5.35%) ⬇️
python/amici/gradient_check.py 81.52% <0.00%> (-4.35%) ⬇️
... and 46 more

@dweindl dweindl requested a review from FFroehlich January 12, 2022 19:36
@dweindl dweindl merged commit a4f6610 into develop Jan 12, 2022
@dweindl dweindl deleted the dlls branch January 12, 2022 20:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants