Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload Model::setParameterScale with vector<int> #1614

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Overload Model::setParameterScale with vector<int> #1614

merged 3 commits into from
Dec 7, 2021

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 7, 2021 •
edited
Loading

@dilpath dilpath requested a review from dweindl December 7, 2021 15:28
@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #1614 (24657e5) into develop (75d94c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1614   +/-   ##
========================================
  Coverage    78.85%   78.85%           
========================================
  Files           68       68           
  Lines        10672    10672           
========================================
  Hits          8415     8415           
  Misses        2257     2257
Flag Coverage Δ
cpp 75.42% <ø> (ø)
petab 67.08% <ø> (ø)
python 68.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FFroehlich
Copy link
Member

👍

@FFroehlich
Copy link
Member

add simple testcase?

dweindl
dweindl approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dilpath dilpath merged commit 254990a into develop Dec 7, 2021
@dilpath dilpath deleted the fix_int_vector_set_parameter_scale branch December 7, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dilpath @FFroehlich @dweindl