Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEtab import: Fixup for 888679, handle TypeError #1522

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 1, 2021

Fixes incomplete exception handling introduced in 8886792

Fixes incomplete exception handling introduced in 8886792
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1522 (e3c2a4e) into develop (8ef53c8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1522   +/-   ##
========================================
  Coverage    79.40%   79.40%           
========================================
  Files           67       67           
  Lines        10413    10413           
========================================
  Hits          8268     8268           
  Misses        2145     2145           
Flag Coverage Δ
cpp 75.82% <ø> (ø)
petab 67.60% <0.00%> (ø)
python 68.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_objective.py 93.14% <0.00%> (ø)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl requested a review from dilpath July 1, 2021 20:26
dweindl added a commit to ICB-DCM/parPE that referenced this pull request Jul 1, 2021
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 85e1e34 into develop Jul 1, 2021
@dweindl dweindl deleted the fixup_888679 branch July 1, 2021 21:09
dweindl added a commit to ICB-DCM/parPE that referenced this pull request Jul 13, 2021
dweindl added a commit to ICB-DCM/parPE that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants