Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReturnData::status for empty ReturnData #1949

Closed
dweindl opened this issue Jan 18, 2023 · 0 comments
Closed

Fix ReturnData::status for empty ReturnData #1949

dweindl opened this issue Jan 18, 2023 · 0 comments
Assignees
@dweindl
Labels
c++ python

Comments

@dweindl
Copy link
Member

dweindl commented Jan 18, 2023

If a simulation fails runAmiciSimulations(...., failfast=True) , an empty ReturnData with status=AMICI_SUCCESS is returned for the skipped conditions, . This is rather confusing. Either we should add a new status, e.g., NOT_RUN, or we just return None instead of ReturnData for these cases.
@dweindl dweindl self-assigned this Feb 11, 2023
dweindl added a commit that referenced this issue Feb 11, 2023
@dweindl
Change default ReturnData::status to AMICI_NOT_RUN
824dfd8 
So far, if a simulation with `runAmiciSimulations(...., failfast=True)` failed, an empty `ReturnData` with `status=AMICI_SUCCESS` was returned for the skipped conditions. This was rather confusing.

This adds a new status: `AMICI_NOT_RUN`.

Fixes #1949
@dweindl dweindl mentioned this issue Feb 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
c++ python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dweindl