Skip to content

Commit

Permalink
Raise in simulate_petab with scaled_parameters=True problem_parameter…
Browse files Browse the repository at this point in the history
…s=None (#1819)

This case was not handled correctly. Just raise for now.
  • Loading branch information
dweindl authored Jul 5, 2022
1 parent 97c84ea commit 61597f2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion python/amici/petab_objective.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ def simulate_petab(
# Use PEtab nominal values as default
problem_parameters = {t.Index: getattr(t, NOMINAL_VALUE) for t in
petab_problem.parameter_df.itertuples()}
scaled_parameters = False
if scaled_parameters:
raise NotImplementedError(
"scaled_parameters=True in combination with "
"problem_parameters=None is currently not supported.")

# number of amici simulations will be number of unique
# (preequilibrationConditionId, simulationConditionId) pairs.
Expand Down

0 comments on commit 61597f2

Please sign in to comment.