fix(淘宝): 修改通知匹配规则，适配更多场景 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIsouler
reviewed
Jan 14, 2025
src/apps/com.taobao.taobao.ts
Outdated
| ], | ||
| matches: | ||
| '[text^="开启系统通知"] + @Image[visibleToUser=true] <<n [vid="poplayer_inner_view"]', | ||
| matches: ['[text*="通知"]', 'Image[visibleToUser=true]'], |
There was a problem hiding this comment.
Image[visibleToUser=true] 并不能快速查询，且这个选择器会匹配上多个节点
There was a problem hiding this comment.
我在测试规则的时候 是能选到目标x号的 我记得有一个规则好像是说 命中多个元素的时候 默认最前面那个 但是没找到出处 你记得吗
There was a problem hiding this comment.
编写规则时应该以唯一节点为目标，Image[visibleToUser=true] 太宽泛了，容易误触，并且在所有选择器都能快速查询的情况下才使用 matches数组，否则不建议使用
src/apps/com.taobao.taobao.ts
Outdated
| @@ -100,13 +100,14 @@ export default defineGkdApp({ | |||
| 'com.taobao.android.tbabilitykit.pop.StdPopContainerActivity', | |||
| 'com.taobao.tao.TBMainActivity', | |||
| 'com.taobao.tao.welcome.Welcome', | |||
| 'com.taobao.tao.welcome.Welcome', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今天发现淘宝系统消息通知更改了文字提示，因此做了适配