BUG: Force dType of discretized image array to int. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If input image array has a dType with max-value smaller than the number of bins, an overflow can occur, causing invalid values and subsequent faillure of texture matrix calculation (e.g. values of '0' or negative values can be present, causing index errors). To prevent this, ensure the output datatype is 'int', which has a large enough dynamic range to prevent overflow (if number of bins is larger than INT_MAX, the extraction will most likely fail anyway, due to size/memory issues).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If input image array has a dType with max-value smaller than the number of bins, an overflow can occur, causing invalid values and subsequent faillure of texture matrix calculation (e.g. values of '0' or negative values can be present, causing index errors).
To prevent this, ensure the output datatype is 'int', which has a large enough dynamic range to prevent overflow (if number of bins is larger than INT_MAX, the extraction will most likely fail anyway, due to size/memory issues).