Update PyRadiomics Logging #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
force-pushed
the
update-logging
branch
2 times, most recently
from
a1963d1 to
17cb20a
Compare
|
@Radiomics/developers. As discussed in the last hangout, I changed the progress reporting in PyRadiomics to make use of the logging package where possible. This therefore also removes the |
Update logging, with mainly added debug messages on various functions throughout the toolbox. Additionally, change how logging is set up in the various scripts used to run PyRadiomics. Instead of using a root logger, keep 'radiomics' logger as 'root' logger, with script/batch specific log messages in the 'radiomics.script' and 'radiomics.batch' logger. This excludes the PyKwalify debug messages from the PyRadiomics log when level is set to DEBUG.
Restructure progress reporting in PyRadiomics to make use of logging package. Add a function `setVerbosity` to control verbosity level of the toolbox (level is specified as a logging level). Replace calls to the `print` function by calls to `logger.info`. This also removes the need for the `verbose` keyword in the settings. When PyRadiomics is used in interactive python, a more verbose output can be obtained via the new `setVerbosity` function, defined at the module level. From the commandline, add an new optional argument (`--verbosity / -v`) to control verbosity (default level: WARNING, and when the argument is added without a value, level is set to INFO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update logging, with mainly added debug messages on various functions throughout the toolbox.
Additionally, change how logging is set up in the various scripts used to run PyRadiomics. Instead of using a root logger, keep
radiomicslogger as 'root' logger, with script/batch specific log messages in theradiomics.scriptandradiomics.batchlogger. This excludes the PyKwalify debug messages from the PyRadiomics log when level is set to DEBUG.