Update for first release #173
Conversation
Update documentation and paramSchema accordingly
Uses featureextractor to define a list of feature classes and features, which is used to check the dictionary provided in the parameters file. Additionally, make the function `getFeatureClasses` a classmethod, so it can be used without having to instantiate `RadiomicsFeaturesExtractor`
| ngtdm: *featurelist | ||
| glrlm: *featurelist | ||
| glszm: *featurelist | ||
| regex;(.+): |
There was a problem hiding this comment.
Out of curiosity - how is this supposed to work?
There was a problem hiding this comment.
To rephrase my comment, my understanding of a schema is that it should help users write and validate parameter files. I have troubles understanding how it would help me with the way it is written at the moment. Maybe it is better to have yml file updated every time a new feature is introduced? I wonder if we go too crazy with the dynamic lookups. At some point they help developer of the library to save a lot of code lines, but can make user life miserable.
There was a problem hiding this comment.
It uses a checking function in schemaFuncs.py to do the actual checking. the regex part just ensures that any keys not dismissed out of hand. It is not possible to use allowempty: True here, as it would include keys that are not allowed.
The reason I use the dynamic lookup is not so much to save code lines, but also to make the addition/removal of feature classes more simple. Now you just have to code the class according to the convention and run a script to generate a baseline, nothing else. This does make some code more complex, but this would be code that wouldn't be subject to much change (a sort of pyradiomics core).
There was a problem hiding this comment.
I understand. However, those config files are more for the user of the library than for the developer. I don't see how this approach helps the user to use the library ... but in any case - ready for merge as far as I am concerned.
|
Added the tag v1.0 to branch master, version is now 1.0 |
Remove experimental/unstable feature classes from the master.
Additionally, make the checking of the option parameters file dynamic:
featureClassdictionary is now checked using a list of feature classes and features generated by usingfeatureextractor