Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please comment on "parse.py" code #217

Closed
wants to merge 8 commits into from

Conversation

chuntian236
Copy link
Collaborator

@chuntian236 chuntian236 commented Nov 16, 2023

Comments on the function for parsing spectra goes in this PR.

parse.py

Jupyter notebook parse_spectra.ipynb

@matthewcarbone
Copy link
Contributor

@chuntian236 before doing anything else, can you remove whatever massive files are adding 200k+ lines of new code? These should not be committed to version control. I'm guessing it's a stray OUTCAR file or something related.

@matthewcarbone matthewcarbone marked this pull request as draft November 16, 2023 20:47
@matthewcarbone matthewcarbone self-requested a review November 16, 2023 20:47
@matthewcarbone
Copy link
Contributor

@chuntian236 gonna close this per our email. Please open a new PR without the huge files. Feel free to do it directly from this main repository. You now have write access. Just don't git push on the master branch! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants