-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the user merge branches. #141
base: master
Are you sure you want to change the base?
Conversation
Does this also help with |
I'm sorry, put my patch seems to work with git merge, with the mergetools, ans with cherry-picking, but patching seems to be another problem. It looks like that there is no way to create a custom "patch" command thar overwrite the default behaviour, but it may be possible to write a custom script that do the sane thing, maybe by temporary jumping to a temp uncrypted git project, run the git add here, copy the file in the current folder, stash it, and replace it with the new version, but I'm not sure that there no better way to proceed… Sorry.
|
Thank you for the reply 👍 |
Will either this or #107 get merged at some point? |
git-crypt is basically unusable without this. Is there any reason @AGWA this never has been merged? |
I tested this PR with the following process: Initiate a repo with git-crypt:
Create a second local repo:
Make modification in both local repos:
Try to merge:
So yeah, it works ! But this requires to start from a fresh repository as the script Thanks @tobiasBora |
if (access(state_mergetool_path.c_str(), F_OK) != 0) { | ||
std::ofstream state_mergetool_file(state_mergetool_path.c_str()); | ||
// |--------------------------------------------------------------------------------| 80 chars | ||
state_mergetool_file << "#!/usr/bin/env bash\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use /bin/sh
instead of /usr/bin/env bash
for better compatibility – not every system ships bash by default. /bin/sh
exists on every *nix system, it’s defined by POSIX, and this script is compatible with POSIX shell.
I know it's been a while, but is there any chance this could be merged provided the issue above gets fixed? :) |
There's also #180 |
A pretty simple pull request that let the user merge branches. This should correct this bug: #140