Timeout forkserver #136
Merged
Timeout forkserver #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to fix some clippy errors.. |
|
I don't like it either when clippy complains "XXX is being shadowed" 😓 |
domenukk
reviewed
May 28, 2021
libafl/src/executors/forkserver.rs
Outdated
|
|
||
| pub fn read_st_timed(&mut self, timeout: &mut TimeVal) -> Result<Option<(usize, i32)>, Error> { | ||
| let mut buf: [u8; 4] = [0u8; 4]; | ||
| let st_read = self.st_pipe.read_end().unwrap(); |
There was a problem hiding this comment.
Maybe use ? instead of unwrap here?
domenukk
reviewed
May 28, 2021
libafl/src/executors/forkserver.rs
Outdated
| &mut copy, | ||
| )?; | ||
| if sret > 0 { | ||
| let rlen = self.st_pipe.read(&mut buf)?; |
|
Looks good, awesome stuff! :) |
domenukk
approved these changes
May 28, 2021
|
Should we maybe change the forkserver example to use the TimeoutForkserver now? |
|
ok |
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
* barebones for TimeoutForkserverExecutor * TimeoutForkserverExecutor * update pid in forkserverexecutor * clppy and other small fixes * doc * fix * no unwrap * read_exact and error handling * fix * semicolon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82 #111
I've made the TimeoutForkserverExecutor that wraps around the normal ForkserverExecutor and can check timeout also. It can be used similarly as the TimeoutExecutor, (just pass the Executor and the Duration to call the constructor).