Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using libafl as a git dependency is noisy #1305

Closed
addisoncrump opened this issue Jun 7, 2023 · 5 comments
Closed

Using libafl as a git dependency is noisy #1305

addisoncrump opened this issue Jun 7, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@addisoncrump
Copy link
Collaborator

addisoncrump commented Jun 7, 2023 •
edited
Loading

Using libafl as a git dependency is very noisy:

image of multiple warning messages with the content "skipping duplicate package"

We should rename crates accordingly.
@addisoncrump addisoncrump added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2023
@addisoncrump
Copy link
Collaborator Author

It also seems to fail in some contexts: astral-sh/ruff#4928 (comment)

@domenukk
Copy link
Member

domenukk commented Jun 7, 2023

For the listings one, why is it built in this case, anyway?
Seems to be related to #1289, @kokkonisd do you know this by any chance?

@kokkonisd
Copy link
Contributor

kokkonisd commented Jun 7, 2023 •
edited
Loading

Huh, interesting, I didn't know it did that.
I guess we could just rename the listing "packages"? Not sure if there's a "more correct"/idiomatic way of fixing this.

kokkonisd added a commit to kokkonisd/LibAFL that referenced this issue Jun 7, 2023
@kokkonisd
Give baby fuzzer listings unique package names
dffb827 
As discussed in [AFLplusplus#1305], it is problematic for the listings to have the
same package name, as they cause warnings to be emitted.
@kokkonisd kokkonisd mentioned this issue Jun 7, 2023
Merged
domenukk pushed a commit that referenced this issue Jun 8, 2023
@kokkonisd
Give baby fuzzer listings unique package names (#1307)
7d67fc7 
As discussed in [#1305], it is problematic for the listings to have the
same package name, as they cause warnings to be emitted.
@domenukk
Copy link
Member

domenukk commented Jun 8, 2023

It also seems to fail in some contexts: astral-sh/ruff#4928 (comment)

This seems to be a different root cause, then? The original issue should be addressed in #1307

@addisoncrump
Copy link
Collaborator Author

Yup! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenukk @addisoncrump @kokkonisd