Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate and release the contact service library to an artifact repository #19

Merged
merged 20 commits into from
Oct 10, 2024
Merged

Isolate and release the contact service library to an artifact repository #19

merged 20 commits into from
Oct 10, 2024

Conversation

Awambeng
Copy link
Collaborator

@Awambeng Awambeng commented Oct 3, 2024 •
edited
Loading

Closes adorsys/eudiw-app#219

@Awambeng Awambeng requested a review from IngridPuppet October 3, 2024 11:15
@Awambeng Awambeng linked an issue Oct 3, 2024 that may be closed by this pull request
Isolate and release the Contact Service library to an artifact repository #16
Closed
@Awambeng Awambeng removed a link to an issue Oct 3, 2024
Isolate and release the Contact Service library to an artifact repository #16
Closed
@Awambeng Awambeng linked an issue Oct 3, 2024 that may be closed by this pull request
Isolate and release the Contact Service library to an artifact repository #16
Closed
IngridPuppet
IngridPuppet requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@IngridPuppet IngridPuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me overall.

packages/contact-service/package.json Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/src/lib/tests/contact-service.spec.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/contact-service.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/model/contact.ts Outdated Show resolved Hide resolved
packages/contact-service/tsconfig.json Outdated Show resolved Hide resolved
packages/contact-service/src/index.ts Outdated Show resolved Hide resolved
@Awambeng Awambeng requested a review from IngridPuppet October 4, 2024 14:40
IngridPuppet
IngridPuppet requested changes Oct 7, 2024
View reviewed changes
packages/contact-service/package.json Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/src/model/Contact.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/tests/contact-service.spec.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/ContactService.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/ContactService.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/tests/contact-service.spec.ts Outdated Show resolved Hide resolved
packages/contact-service/src/lib/ContactService.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@Awambeng Awambeng requested a review from IngridPuppet October 8, 2024 08:34
@Awambeng Awambeng requested a review from IngridPuppet October 9, 2024 13:45
IngridPuppet
IngridPuppet reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@IngridPuppet IngridPuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things.

packages/contact-service/README.md Outdated Show resolved Hide resolved
packages/contact-service/src/lib/ContactService.ts Outdated Show resolved Hide resolved
@Awambeng Awambeng requested a review from IngridPuppet October 9, 2024 16:39
@Awambeng
fix failing tests
bdbbb67
@Awambeng
updated status-service library name, adjusted imports in the contact-…
5023907 
…service lib and tested uncovered branch for 100% test coverage
@Awambeng Awambeng requested a review from IngridPuppet October 10, 2024 07:13
IngridPuppet
IngridPuppet reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@IngridPuppet IngridPuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of the status-service library introduced as a more general library for common things that will be needed across service libraries?

@Awambeng Awambeng requested a review from IngridPuppet October 10, 2024 08:26
@Awambeng Awambeng merged commit 354e337 into main Oct 10, 2024
3 checks passed
@Awambeng Awambeng deleted the 16-isolate-and-release-the-contact-service-library-to-an-artifact-repository branch October 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngridPuppet IngridPuppet IngridPuppet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Isolate and release the Contact Service library to an artifact repository
2 participants
@Awambeng @IngridPuppet