-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing a library which interacts with the storage library for generating and managing multiple DID Identities for the wallet #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forkimenjeckayang
changed the title
Initital commit for library files
Implementing a library which interacts with the storage library for generating and managing multiple DID Identities for the wallet
Oct 3, 2024
IngridPuppet
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you refactor your logic to make it extensible to more DID methods? did:key is a good start, but we'll need did:peer in the near future. It'll be great to add support for it in a seamless manner.
packages/multiple-did-identities/src/lib/multiple-did-identities.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/lib/multiple-did-identities.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/tests/multi-did-identities.spec.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/lib/multiple-did-identities.ts
Outdated
Show resolved
Hide resolved
IngridPuppet
requested changes
Oct 21, 2024
packages/multiple-did-identities/src/did-methods/DidMethodFactory.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/did-methods/DidPeerMethod.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/__tests__/did-identity-service.spec.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/did-methods/DidKeyMethod.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/__tests__/did-methods.spec.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/repository/DidRepository.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/repository/DidRepository.ts
Outdated
Show resolved
Hide resolved
IngridPuppet
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library enables the generation of multiple DIDs, where each call to the function generates a new DID. The private key of each DID identity is encrypted before being stored, allowing for secure management. The library provides functionalities to store, delete, and retrieve DIDs efficiently using the storage library.
Closes https://github.com/adorsys/eudiw-app/issues/218