-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a lib for contact-exchange with multipe identities #15
Conversation
3fd5c76
to
7644f73
Compare
05af432
to
0277f33
Compare
Please revisit the naming conventions of your files for more standardisation. The rest of the libraries use all the same PascalCase naming. |
75783d3
to
2241b78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flow in general looks good!
what I would add, for completion is a parser.
The oob as a url format with a b64 encoded part:
https://identity.foundation/didcomm-messaging/spec/#standard-message-encoding
The rest, looks good! Thanks.
packages/contact-exchange/src/tests/ProcessOOBInvitation.test.ts
Outdated
Show resolved
Hide resolved
packages/contact-exchange/src/tests/ProcessOOBInvitation.test.ts
Outdated
Show resolved
Hide resolved
Take a look at this notebook to understand better didcomm and further reference: https://github.com/adorsys/eudiw-app/issues/220#issuecomment-2402368935 |
3d441b7
to
1156e7d
Compare
Okay @hugoib, |
packages/contact-exchange/src/tests/HandleOOBInvitation.test.ts
Outdated
Show resolved
Hide resolved
2241b78
to
211175d
Compare
…ing and wallet management
211175d
to
77468c4
Compare
I implemented a library for handling contact exchanges between wallets, focusing on Out-Of-Band (OOB) invitations within the DIDComm messaging framework. The library allows wallets to process OOB invitations and manage contacts across multiple identities.
Key Features
This implementation aligns with the DIDComm specifications and OOB messaging. It is designed to handle a key requirement of enabling communication between wallets via contact exchange.
Closes https://github.com/adorsys/eudiw-app/issues/220