Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a lib for contact-exchange with multipe identities #15

Closed
wants to merge 2 commits into from

Conversation

Ogenbertrand
Copy link
Collaborator

@Ogenbertrand Ogenbertrand commented Oct 1, 2024

I implemented a library for handling contact exchanges between wallets, focusing on Out-Of-Band (OOB) invitations within the DIDComm messaging framework. The library allows wallets to process OOB invitations and manage contacts across multiple identities.

Key Features

  • OOB Invitation Processing: The library includes a function to parse and process DIDComm OOB invitations, extracting relevant details like service endpoints and recipient keys.
  • Wallet and Contact Management: A Wallet class is implemented to manage contacts for multiple identities, supporting the addition, retrieval, and cross-identity access to contacts.
  • Test Coverage: Comprehensive unit tests have been added for OOB invitation processing and wallet functionalities using Jest.

This implementation aligns with the DIDComm specifications and OOB messaging. It is designed to handle a key requirement of enabling communication between wallets via contact exchange.

Closes https://github.com/adorsys/eudiw-app/issues/220

@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch from 3fd5c76 to 7644f73 Compare October 3, 2024 13:00
@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch 4 times, most recently from 05af432 to 0277f33 Compare October 7, 2024 16:00
@hugoib
Copy link
Collaborator

hugoib commented Oct 9, 2024

Please revisit the naming conventions of your files for more standardisation. The rest of the libraries use all the same PascalCase naming.

@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch from 75783d3 to 2241b78 Compare October 9, 2024 12:38
Copy link
Collaborator

@hugoib hugoib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flow in general looks good!

what I would add, for completion is a parser.

The oob as a url format with a b64 encoded part:

https://identity.foundation/didcomm-messaging/spec/#standard-message-encoding

The rest, looks good! Thanks.

package.json Outdated Show resolved Hide resolved
packages/contact-exchange/package.json Outdated Show resolved Hide resolved
packages/contact-exchange/README.md Outdated Show resolved Hide resolved
@hugoib
Copy link
Collaborator

hugoib commented Oct 9, 2024

Take a look at this notebook to understand better didcomm and further reference:

https://github.com/adorsys/eudiw-app/issues/220#issuecomment-2402368935

@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch from 3d441b7 to 1156e7d Compare October 10, 2024 09:11
@Ogenbertrand
Copy link
Collaborator Author

Take a look at this notebook to understand better didcomm and further reference:

adorsys/eudiw-app#220 (comment)

Okay @hugoib,
Thank you.

@Ogenbertrand Ogenbertrand requested a review from hugoib October 10, 2024 09:16
@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch 6 times, most recently from 2241b78 to 211175d Compare October 11, 2024 10:34
@Ogenbertrand Ogenbertrand force-pushed the feat-contact-exchange branch from 211175d to 77468c4 Compare October 11, 2024 10:39
@Ogenbertrand Ogenbertrand deleted the feat-contact-exchange branch October 11, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants