Feature/scan info #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christiantyemele
requested review from
bryandino673,
stephane-segning and
Ngha-Boris
Ngha-Boris
requested changes
May 6, 2024
There was a problem hiding this comment.
Hello @Christiantyemele one of the checks failed please consider checking that out.
@Ngha-Boris issue resolved plz review |
Ngha-Boris
reviewed
May 6, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Please @Christiantyemele remove this file. Here we're using only yarn.
There was a problem hiding this comment.
stephane-segning
requested changes
May 6, 2024
src/index.scss
Outdated
Comment on lines
5
to
77
| .container { | ||
| display: flex; | ||
| padding: 1em; | ||
| align-items: center; | ||
| min-width: 60dvh; | ||
| background-color: gainsboro; | ||
| border: 2px solid white; | ||
| justify-content: space-evenly; | ||
| border-radius: 10px; | ||
| max-width: 580px; | ||
| } | ||
|
|
||
| .main-container { | ||
| margin-top: 5em; | ||
| display: flex; | ||
| justify-content: center; | ||
| min-height: 368px; | ||
| min-width: 172px; | ||
| } | ||
|
|
||
| .submit { | ||
| margin: 1em; | ||
| color: blue; | ||
| } | ||
|
|
||
| .cancel { | ||
| margin: 1em; | ||
| color: red; | ||
| } | ||
|
|
||
| .buttons { | ||
| display: grid; | ||
| justify-content: space-evenly; | ||
| } | ||
|
|
||
| .inputs { | ||
| margin: 0.5em; | ||
| } | ||
|
|
||
| .title { | ||
| display: flex; | ||
| justify-content: center; | ||
| margin-bottom: 2em; | ||
| font-size: 1.3em; | ||
| } | ||
|
|
||
| .head { | ||
| background: rgb(226 236 245); | ||
| font-size: 0.99em; | ||
| line-height: 1.1em; | ||
| } | ||
|
|
||
| .add::after { | ||
| content: 'Add Scan'; | ||
| position: absolute; | ||
| visibility: hidden; | ||
| } | ||
|
|
||
| .parent-button { | ||
| display: grid; | ||
| justify-content: center; | ||
| align-items: end; | ||
| margin-top: 30em; | ||
| } | ||
|
|
||
| .add:hover::after { | ||
| visibility: visible; | ||
| opacity: 1; | ||
| } | ||
|
|
||
| .add { | ||
| cursor: pointer; | ||
| } |
There was a problem hiding this comment.
Remove this and use tailwind only
There was a problem hiding this comment.
Done sir @stephane-segning
Christiantyemele
force-pushed
the
feature/ScanInfo
branch
from
0a48678 to
95e39ad
Compare
stephane-segning
requested changes
May 7, 2024
src/components/Scan-Button.tsx
Outdated
| @@ -0,0 +1,11 @@ | |||
| import { Link } from 'react-router-dom'; | |||
|
|
|||
| export const InfoButton = () => { | |||
There was a problem hiding this comment.
This component's name doesn't match the file name
There was a problem hiding this comment.
Done sir @stephane-segning
src/app.tsx
Outdated
There was a problem hiding this comment.
Cancel these changes
bryandino673
reviewed
May 7, 2024
bryandino673
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.