Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD pipeline implementation for frontend of powerpayapp #61

Merged
merged 17 commits into from
Mar 6, 2024

Conversation

Koufan-De-King
Copy link
Collaborator

-A CI file named build-and-deploy-pwa.yaml was added to the workflow folder.
-Some additional configurations in the power-pay-frontend directory were made, such as in the package.json file to make the deployment possible.
-Sorry for the too many commits, that's because the deployment had to be tested many times over.

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Koufan-De-King. Please proceed to the changes

power-pay-frontend/index.html Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
power-pay-frontend/src/App.tsx Outdated Show resolved Hide resolved
power-pay-frontend/vite.config.ts Outdated Show resolved Hide resolved
.github/workflows/build-and-deploy-pwa.yaml Outdated Show resolved Hide resolved
@Koufan-De-King
Copy link
Collaborator Author

Understood sir. Adjusting the changes immediately!

Copy link
Collaborator Author

@Koufan-De-King Koufan-De-King left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were done.

power-pay-frontend/index.html Outdated Show resolved Hide resolved
power-pay-frontend/vite.config.ts Outdated Show resolved Hide resolved
power-pay-frontend/src/App.tsx Outdated Show resolved Hide resolved
uses: actions/upload-artifact@v3
with:
name: production-files
path: power-pay-frontend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why taking this path? Why not power-pay-frontend/build ?

Copy link
Collaborator Author

@Koufan-De-King Koufan-De-King Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aiming for a match between the path and the publish_dir. Should I also change the publish_dir to the same or just the path?

@stephane-segning
Copy link
Contributor

@Koufan-De-King i said power-pay-frontend/build. But instead of build you should try with dist then

@Koufan-De-King
Copy link
Collaborator Author

I have tried with power-pay-frontend/dist

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@stephane-segning stephane-segning merged commit 86a2f15 into ADORSYS-GIS:main Mar 6, 2024
3 checks passed
Christiantyemele pushed a commit to Christiantyemele/forked-e2e-banking-app that referenced this pull request Apr 9, 2024
…werpayapp (ADORSYS-GIS#61)

* feat(CI/CD): testing CI/CD pipeline for deployment of frontend
* feat(CI/CD): properly configured files for frontend deployment
Christiantyemele pushed a commit to Christiantyemele/forked-e2e-banking-app that referenced this pull request Apr 9, 2024
…werpayapp (ADORSYS-GIS#61)

* feat(CI/CD): testing CI/CD pipeline for deployment of frontend
* feat(CI/CD): properly configured files for frontend deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants