Replace home with migration screen in legacy app #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy channels have now all been closed and the legacy app can only be used to import closed legacy channels for users who uninstalled the app. The settings menu has also been cleaned.
Also made switch-to-legacy button more visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, pre-splice channels (used by the legacy Android app a.k.a v1) needed to be migrated to v2 since September 2023. A free migration flow was available until October 2024.
See this post for details about the splicing v2 update: https://acinq.co/blog/phoenix-splicing-update
In October 2024, all remaining legacy channel have been closed (i.e. funds are moved back on-chain to the "final wallet"). In some cases, for some specific channels type, the closing also needs interaction from the wallet to complete. To perform this interaction the legacy code must be used, so the legacy app still needs to be available.
To help with this migration and let users understand where their funds are, the legacy main screen now only contains the migration prompt with the final wallet balance, as well as access to the settings in case the user needs to complete the channels closing.
Migration prompt (in v1)
Spending from final wallet (in v2)