Handle new outgoing payment failures #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpad85
commented
May 15, 2024
phoenix-shared/src/commonMain/kotlin/fr.acinq.phoenix/db/payments/OutgoingPartStatusType.kt
Outdated
Show resolved
Hide resolved
dpad85
force-pushed
the
channel-error-sending-failed
branch
2 times, most recently
from
20d2221 to
0c1529b
Compare
Outgoing LN parts have a new failure type, which will help provide more meaningful error messages. The payments database interface has also changed to accomodate these new types. See ACINQ/lightning-kmp#634
dpad85
force-pushed
the
channel-error-sending-failed
branch
from
0c1529b to
a149ad6
Compare
robbiehanson
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the new outgoing payment failures types added in ACINQ/lightning-kmp#634.
There is a small impact on the payments database, as the status of failed parts are stored using a
code: Intjson (with an optional String message).@robbiehanson we should remove the details for failed parts on iOS. Instead, show a single error message using the
OutgoingPaymentFailure.explain()method that will pick the most pertinent error for a given payment (will return either aFinalFailureerror, or aPart.Status.Failure)