Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TLV ranges for Offers #716

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Update TLV ranges for Offers #716

merged 3 commits into from
Oct 16, 2024

Conversation

thomash-acinq
Copy link
Member

The spec now allows the ranges [1000000000, 1999999999] and [2000000000, 2999999999] for offer and invoice request TLVs in addition to the previous [1, 79] and [80, 159].

@thomash-acinq
Update TLV ranges for Offers
d95f1c8 
The spec now allows the ranges [1000000000, 1999999999] and [2000000000, 2999999999] for offer and invoice request TLVs in addition to the previous [1, 79] and [80, 159].
@thomash-acinq thomash-acinq requested a review from t-bast October 16, 2024 09:01
t-bast
t-bast reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/commonMain/kotlin/fr/acinq/lightning/wire/OfferTypes.kt Outdated Show resolved Hide resolved
t-bast
t-bast previously approved these changes Oct 16, 2024
View reviewed changes
@t-bast
Copy link
Member

t-bast commented Oct 16, 2024

I haven't checked if we have a unit test verifying that we accept invoice_requests that contain such experimental TLVs, can you check if that's the case or add one?

@thomash-acinq thomash-acinq mentioned this pull request Oct 16, 2024
Merged
@thomash-acinq
Copy link
Member Author

Added some tests

t-bast
t-bast approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@thomash-acinq thomash-acinq merged commit d19bc3e into master Oct 16, 2024
2 checks passed
@thomash-acinq thomash-acinq deleted the experimental-range branch October 16, 2024 10:11
@dpad85 dpad85 mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomash-acinq @t-bast