Include min_final_cltv_expiry_delta in blinded paths
#694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a payer uses the current block height as the expiry for the payments they send to us, we will reject it because we need to have a few blocks to potentially force-close and get our funds back safely. With blinded paths, we don't need to rely on payers to add a safety margin: we can directly encode it in the blinded path's total expiry delta.
We must use the most restrictive value for `htlc_minimum`, not the least restrictive one. When we don't have the remote channel update we should use the value from our node params. The `htlc_maximum` is allowed to be twice the payment amount according to the BOLTs: we reflect that in the blinded path data.
thomash-acinq
previously approved these changes
Aug 23, 2024
|
Should we fail the invoice request if the amount is too low? |
I thought about it, this is probably a good idea indeed. I'll integrate it into this PR 👍 |
We reject invoice requests that specify an amount below our `htlc_minimum`. It doesn't make sense to attempt that payment, it won't be relayed by our peer.
Done in 39f2413 |
thomash-acinq
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a payer uses the current block height as the expiry for the payments they send to us, we will reject it because we need to have a few blocks to potentially force-close and get our funds back safely.
With blinded paths, we don't need to rely on payers to add a safety margin: we can directly encode it in the blinded path's total expiry delta.