Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of onion messages #643

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix serialization of onion messages #643

merged 1 commit into from
May 21, 2024

Conversation

thomash-acinq
Copy link
Member

The onion routing packet's size is 66 bytes more than its payload's size. We were taking this into account in the read function but not in the write one.

@thomash-acinq thomash-acinq requested a review from t-bast May 20, 2024 14:36
vincenzopalazzo
vincenzopalazzo approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4bbfdea

@thomash-acinq thomash-acinq merged commit e63b537 into master May 21, 2024
2 checks passed
@thomash-acinq thomash-acinq deleted the onion-message-codec branch May 21, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomash-acinq @vincenzopalazzo @t-bast