Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString to payment part failures #638

Merged
merged 2 commits into from
May 15, 2024
Merged

Add toString to payment part failures #638

merged 2 commits into from
May 15, 2024

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 15, 2024

Follow-up to #634.

This makes FinalFailure.explain() return consistent results.

This makes `FinalFailure.explain()` return consistent results.
@pm47 pm47 requested a review from t-bast May 15, 2024 12:23
@t-bast
Copy link
Member

t-bast commented May 15, 2024

It was on purpose that this doesn't have a toString(), since wallet applications must provide their own localized string for each failure (this is in the comment on that trait). Why do you need it?

@pm47
Copy link
Member Author

pm47 commented May 15, 2024

PaymentFailure also must be localized, but we still provide human-readable toStrings.

I'm trying to avoid doing this on phoenixd: ACINQ/phoenixd@27799db

t-bast
t-bast previously approved these changes May 15, 2024
@pm47 pm47 merged commit 66c1038 into master May 15, 2024
2 checks passed
@pm47 pm47 deleted the part-failure-tostring branch May 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants