Improvements to the OfferManager
#633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always use the invoice's `node_id`, so instead of duplicating this argument we can extract it automatically from the invoice. It avoids mistakes that could mess up our accounting.
And rename top-level `SendMessage` to `SendOnionMessage`.
We may want to display a spinner in the UI while requesting the invoice for an offer payment, to quickly report back when the recipient cannot be contacted. This means we need to fail as soon as the timeout provided is hit, so we cannot rely on a regular background task. We instead create a dedicated coroutine for each payment, with the timeout provided in the `PayOffer` request.
This commit keeps the business logic mostly unchanged, but re-works the error handling to ensure that we log as much details as possible to help troubleshoot compatibility issues. It adds support for sending `invoice_error` on some error cases to help debug potential issues. When the introduction node of the recipient is our trampoline node, we remove an unnecessary hop in the onion message.
Merged
thomash-acinq
force-pushed
the
offer-manager
branch
from
598068f to
ec69a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is targeting #624 and adds some improvements and refactoring. Each commit is independent and should be reviewed separately (the commit messages contain useful details about the commit itself). This PR fixes the comments from my latest review of #624.
The main changes are: