Generate default deterministic offer #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
t-bast
force-pushed
the
deterministic-offer
branch
from
3ce27f4 to
6a971e5
Compare
t-bast
force-pushed
the
deterministic-offer
branch
from
6a971e5 to
79bd875
Compare
Add the option to generate a default, deterministic offer that can be restored based on the node's seed and the trampoline node it uses. This offer has the minimal amount of information necessary. It doesn't expire, which makes it suitable to save for long-term, recurring payments.
When we include a blinded path in the offer, it doesn't make sense to include an `offer_node_id`. When receiving an `invoice_request`, we will signed the corresponding invoice with the blinded private key matching the blinded path used by the sender.
This allows us to deterministically generate multiple offers, with different descriptions, based on our seed and trampoline node only. We then don't need to store those offers in a DB since they can be recomputed on-the-fly based on the description alone.
t-bast
force-pushed
the
deterministic-offer
branch
from
79bd875 to
c1e4f9a
Compare
The offer description has been made optional when the offer does not contain an amount. We leverage that in our default offer to save a few bytes.
thomash-acinq
previously approved these changes
Apr 24, 2024
thomash-acinq
approved these changes
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to generate a default, deterministic offer that can be restored based on the node's seed and the trampoline node it uses. This offer has the minimal amount of information necessary. It doesn't expire, which makes it suitable to save for long-term, recurring payments.
We also include the latest changes to the specification that allow us to create this minimal offer:
offer_node_idcan be omitted if a blinded path is providedoffer_descriptioncan be omitted if the offer doesn't have an amount