Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stfu type to decode logic #595

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Add Stfu type to decode logic #595

merged 2 commits into from
Feb 8, 2024

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Feb 7, 2024

Oops! 😄

@pm47 pm47 requested review from remyers and t-bast February 7, 2024 14:03
t-bast
t-bast previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, we should have added a decoding test to catch that earlier!

remyers added a commit to remyers/lightning-kmp that referenced this pull request Feb 8, 2024
@remyers
Add stfu to splice encode/decode test
af1131f 
As a addition to PR ACINQ#595
remyers
remyers requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that!

As @t-bast suggested, we should also add the corresponding tests for completeness. See af1131f8d.

pm47 pushed a commit that referenced this pull request Feb 8, 2024
@remyers @pm47
Add stfu to splice encode/decode test
b86b1e5 
As a addition to PR #595
@pm47
Copy link
Member Author

pm47 commented Feb 8, 2024

Rebased.

@pm47 pm47 requested a review from remyers February 8, 2024 10:43
@pm47 pm47 merged commit 77003f9 into master Feb 8, 2024
2 checks passed
@pm47 pm47 deleted the stfu-decode branch February 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

@remyers remyers remyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm47 @remyers @t-bast