Purge pending incoming payments on disconnection #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were keeping pending incoming payments in the internal state of the `IncomingPaymentHandler` even when disconnected. This could lead to inconsistencies with the channel state: if an HTLC that was added to the `IncomingPaymentHandler` was failed by another instance of the app (for example a background task), that failure wouldn't propagate to the state of the `IncomingPaymentHandler`. This can lead to partially fulfilled payments, where we think we have received the complete payment, but one of the part was actually failed so we shouldn't release the preimage.
pm47
previously approved these changes
Jan 18, 2024
src/commonMain/kotlin/fr/acinq/lightning/payment/IncomingPaymentHandler.kt
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were keeping pending incoming payments in the internal state of the
IncomingPaymentHandlereven when disconnected. This could lead to inconsistencies with the channel state: if an HTLC that was added to theIncomingPaymentHandlerwas failed by another instance of the app (for example a background task), that failure wouldn't propagate to the state of theIncomingPaymentHandler. This can lead to partially fulfilled payments, where we think we have received the complete payment, but one of the part was actually failed so we shouldn't release the preimage.