Apply 0-reserve to both peers #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously only applied 0-reserve to the non-initiator when the feature bit was active. We should apply it to both sides of the channel. This reduces the liquidity requirements on the initiator side, and allows receiving more funds over lightning before requiring a splice to get more inbound liquidity.
t-bast
force-pushed
the
remote-zero-reserve
branch
from
1bb2d36 to
025aa27
Compare
pm47
approved these changes
Nov 10, 2023
| @@ -515,11 +508,11 @@ data class FullCommitment( | |||
| val fundingTxId: ByteVector32 = commitInput.outPoint.txid | |||
| val fundingAmount = commitInput.txOut.amount | |||
| val localChannelReserve = when { | |||
| params.channelFeatures.hasFeature(Feature.ZeroReserveChannels) && !params.localParams.isInitiator -> 0.sat | |||
| params.channelFeatures.hasFeature(Feature.ZeroReserveChannels) -> 0.sat | |||
There was a problem hiding this comment.
The duplication between Commitments and FullCommitments shows that there is some cleanup to do
There was a problem hiding this comment.
True, but I'm not sure how it could be cleaned up though, so I'm leaving it as-is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only applied 0-reserve to the non-initiator when the feature bit was active. We should apply it to both sides of the channel.
This reduces the liquidity requirements on the initiator side, and allows receiving more funds over lightning before requiring a splice to get more inbound liquidity.
This doesn't create any backwards-compatibility issue on the
lightning-kmpside, because if we release with that change, we simply allow our peer to dip into their reserve, which they may or may not do (so we can merge this PR whenever we want). On the eclair side, we can "activate" this when the Phoenix node also supportsquiescence, which implicitly means that it contains this change. In the longer term, we can clean-up those requirements as being simply dependent on the 0-reserve feature bit.Fixes #552