Deal with channels with fees=0 when computing a route #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araspitzu
changed the title
…not required by the channel_update
araspitzu
force-pushed
the
deal_with_channels_with_zero_fees
branch
from
9d8f319 to
0765818
Compare
araspitzu
changed the title
araspitzu
changed the title
sstone
requested changes
Mar 25, 2019
| val g = makeGraph(updates) | ||
|
|
||
| val route1 = Router.findRoute(g, a, e, DEFAULT_AMOUNT_MSAT, numRoutes = 1, routeParams = DEFAULT_ROUTE_PARAMS) | ||
| assert(route1.map(hops2Ids) === Success(1 :: 3 :: Nil)) |
There was a problem hiding this comment.
I don't see where we test that we "treat channels with fees=0 as if they had feeBase=1msat" ?
There was a problem hiding this comment.
The name has become misleading after i changed the behavior of the implementation, initially we wanted to ignore the 0-fee channels and that test was asserting exactly that.
There was a problem hiding this comment.
How about 077a4a4?
sstone
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channels with feeBase=0 and feeProportional=0 cause issues to the path-finding algorithm, this PR makes eclair consider those channel as feeBase=1msat when computing a route but then when the payment is sent out we use its actual fee (zero).