API: replace JSON-RPC by named parameters #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use `signrawtransaction` anymore, which was deprecated in Bitcoin Core 0.17 and will be removed in 0.18. This means that we don't support 0.16.3 and older.
We download bitcoin core and check with maven now.
Plus minor code reformatting for some tests.
Check that we handle errors properly when signrawtransactionwithwallet returns multiple errors.
Short options adds a jq filter for some methods such as channels or channel in order to ouput a smaller and more readable json. Color option has been removed because it adds ansi special characters which breaks jq piping on some systems.
dpad85
reviewed
Mar 26, 2019
sstone
previously requested changes
Mar 26, 2019
eclair-core/src/test/scala/fr/acinq/eclair/api/ApiServiceSpec.scala
Outdated
Show resolved
Hide resolved
dpad85
reviewed
Mar 26, 2019
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/api/Service.scala
pm47
approved these changes
Mar 26, 2019
sstone
approved these changes
Mar 26, 2019
dpad85
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the existing API functionalities over a new structure of HTTP endpoints, with the biggest difference being the usage of named parameters for the requests (responses are unchanged). RPC methods have become endpoints and the parameters for each are now passed via form-params (clients must use the header "Content-Type" : "multipart/form-data"), this allows for a clearer interpretation of the parameters and results in more elegant parsing code on the server side. It is possible to still use the old API version via a configuration key.