Get rid of various unnecessary warnings in logs #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use an explicit event in the `Peer` when watching for child channel actors being terminated. This should get rid of the warnings in the logs about the `Terminated` event not being handled, or at least provide us more hints of which actors aren't properly being tracked.
We weren't watching for the right event, which creates a lot of log lines saying that the `Disconnecting` event is unhandled.
If we receive an outdated closing message, we ignore it without creating a warning in the logs.
We ignore HTLC settlement commands while we're disconnected, they will be retried once the channel has been reestablished. We also ignore commands asking us to sign the latest state or update fees.
thomash-acinq
approved these changes
Jan 15, 2025
sstone
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a ton of warnings in our logs that can be avoided by correctly handling some events in states where we should simply ignore them, for example when a channel is offline. This should help us reduce the size of our logs files.