Add configurable threshold on maximum anchor fee #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously bumped up to 5% of our channel balance when no HTLCs were at risk. For large channels, 5% is an unreasonably high value. In most cases it doesn't matter, because the transaction confirms before we try to bump it to unreasonable levels. But if the commitment transaction was pruned and couldn't be relayed to miners, then eclair would keep trying to bump until it reached that threshold. We now restrict this to a value configurable by the node operator. Note that when HTLCs are at risk, we still bump up to the HTLC amount, which may be higher than the new configuration parameter: we want that behavior as a scorched earth strategy against pinning attacks.
We add a new limit to the feerate used for fee-bumping, based on the fastest feerate returned by our fee estimator. It doesn't make sense to use much higher values, since this feerate should guarantee that the transaction is included in the next block.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
- Coverage 85.98% 85.93% -0.05%
==========================================
Files 217 217
Lines 18248 18250 +2
Branches 800 759 -41
==========================================
- Hits 15690 15683 -7
- Misses 2558 2567 +9
|
pm47
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously bumped up to 5% of our channel balance when no HTLCs were at risk. For large channels, 5% is an unreasonably high value. In most cases it doesn't matter, because the transaction confirms before we try to bump it to unreasonable levels. But if the commitment transaction was pruned and couldn't be relayed to miners, then eclair would keep trying to bump until it reached that threshold. We now restrict this to a value configurable by the node operator. Note that when HTLCs are at risk, we may still bump up to the HTLC amount, which may be higher than this new configuration parameter.
We also limit the feerate used for fee-bumping based on the fastest feerate returned by our fee estimator. It doesn't make sense
to use much higher values, since this feerate should guarantee that the transaction is included in the next block.