Remove reserve check if splice contribution is positive #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If remote has a positive contribution, we do not check their post-splice reserve level, because they are improving their situation, even if they stay below the requirement. Note that if local splices-in some funds in the same operation, remote post-splice reserve may actually be worse than before, but that's not their fault.
t-bast
approved these changes
Nov 3, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2771 +/- ##
==========================================
+ Coverage 85.79% 85.84% +0.04%
==========================================
Files 216 216
Lines 18127 18129 +2
Branches 738 775 +37
==========================================
+ Hits 15552 15562 +10
+ Misses 2575 2567 -8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If remote has a positive contribution, we do not check their post-splice reserve level, because they are improving their situation, even if they stay below the requirement. Note that if local splices-in some funds in the same operation, remote post-splice reserve may actually be worse than before, but that's not their fault.