Clarify tx publisher context and logging #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
tx-publisher-log
branch
2 times, most recently
from
c882299 to
6b317fe
Compare
pm47
previously approved these changes
Jan 19, 2022
This data class is actually used for more than logging, we also use it to track the id of a publish request. We also switch to a different MDC key for transaction publishing instead of re-using the paymentId one.
t-bast
force-pushed
the
tx-publisher-log
branch
from
6b317fe to
bb00974
Compare
pm47
approved these changes
Jan 19, 2022
t-bast
added a commit
that referenced
this pull request
Feb 16, 2022
We changed the logging MDC key for tx-publishing in #2131, but forgot to add a formatting rule in logback.xml for that new field, so it wasn't written to logs.
t-bast
added a commit
that referenced
this pull request
Feb 17, 2022
We changed the logging MDC key for tx-publishing in #2131, but forgot to add a formatting rule in logback.xml for that new field, so it wasn't written to logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data class is actually used for more than logging, we also use it to track the id of a publish request.
We also switch to a different MDC key for transaction publishing instead of re-using the
paymentIdone.