Abort HTLC tx publisher if remote commit confirms

[t-bast]

If the remote commit confirms before our local commit, there is no reason to try to publish our HTLC transactions, we will instead directly claim the htlc outputs from the remote commit.

We previously checked timelocks before checking preconditions, which in this case means we would be waiting for a confirmation on our local commit forever. We now check preconditions before timelocks, and added a precondition that verifies that the remote commit isn't confirmed before publishing our HTLC txs.

It wasn't a big issue, we just had a watch that would linger forever and a few idle actors (until the channel closes and the channel actors stops, which stops all its publisher children), but we can easily avoid it without making the code more complex.

[codecov-commenter]

Codecov Report

Merging #2080 (905f01e) into master (9792c72) will decrease coverage by 0.01%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #2080      +/-   ##
==========================================
- Coverage   87.58%   87.56%   -0.02%     
==========================================
  Files         166      166              
  Lines       12717    12725       +8     
  Branches      536      556      +20     
==========================================
+ Hits        11138    11143       +5     
- Misses       1579     1582       +3     

Impacted Files	Coverage Δ
...clair/channel/publish/ReplaceableTxPublisher.scala	86.81% <78.57%> (+0.60%)	⬆️
...main/scala/fr/acinq/eclair/router/Validation.scala	90.76% <0.00%> (-1.54%)	⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala	87.78% <0.00%> (-0.08%)	⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala	97.56% <0.00%> (+1.62%)	⬆️

[pm47]

LGTM