Clarify route blinding types #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rename the EncryptedRecipientData types. The data it contains is namespaced to usages for route blinding, so we make that explicit. This way if future scenarios use another kind of encrypted tlv stream we won't have name clashes (e.g. encrypted state backup). We also update the route blinding test vectors to the final spec version.
t-bast
commented
Nov 9, 2021
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/RouteBlinding.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rename the
EncryptedRecipientDatatypes. The data it contains is namespaced to usages for route blinding, so wemake that explicit. In onion messages, since route blinding can be used in the forward direction, it's not always data encrypted by the recipient, so we drop that part.
This way if future scenarios use another kind of encrypted tlv stream we won't have name clashes (e.g. encrypted state backup).
We also update the route blinding official test vectors.