Add log file for important notifications #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be made catchable by AlarmBot plugin (maybe publish some kind of event to stream)? This use case fits it like a glove. |
Yes definitely. I planned on creating an event, but wasn't sure how it would be used. |
Yes. |
t-bast
force-pushed
the
node-operator-notifications
branch
from
25b0a2d to
30c9bd7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
- Coverage 87.73% 87.63% -0.10%
==========================================
Files 159 159
Lines 12455 12471 +16
Branches 522 545 +23
==========================================
+ Hits 10927 10929 +2
- Misses 1528 1542 +14
|
pm47
reviewed
Oct 7, 2021
t-bast
force-pushed
the
node-operator-notifications
branch
from
c8fa2cb to
78efe48
Compare
Done in 78efe48 |
|
Needs rebase, otherwise LGTM. |
Add a new log file for important notifications that require an action from the node operator. Using a separate log file makes it easier than grepping specific messages from the standard logs, and lets us use a different style of messaging, where we provide more information about what steps to take to resolve the issue. We rely on an event sent to the event stream so that plugins can also pick it up and connect with notification systems (push, messages, mails, etc).
t-bast
force-pushed
the
node-operator-notifications
branch
from
78efe48 to
72ba251
Compare
|
Rebased |
pm47
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new log file for important notifications that require an action from the node operator.
Using a separate log file makes it easier than grepping specific messages from the standard logs, and lets us use a different style of messaging, where we provide more information about what steps to take to resolve the issue.
We rely on an event sent to the event stream so that plugins can also pick it up and connect with notification systems (push, messages, mails, etc).