Add support for option_compression #1956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
advertize-compression-algorithms
branch
2 times, most recently
from
aad8bba to
e04b47e
Compare
|
Can you spin up a testnet3 node with this for me to test against? |
t-bast
force-pushed
the
advertize-compression-algorithms
branch
from
e04b47e to
fa3c54f
Compare
t-bast
force-pushed
the
advertize-compression-algorithms
branch
3 times, most recently
from
8f0229f to
7c1f245
Compare
Implement lightning/bolts#825 This lets us specify which compression algorithms we support and use one that our peer supports as well when syncing the network graph.
t-bast
force-pushed
the
advertize-compression-algorithms
branch
from
7c1f245 to
84a6a8b
Compare
|
@TheBlueMatt and I tested cross-compatibility between this branch and LDK on testnet3: everything looks good! |
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
+ Coverage 87.57% 87.59% +0.01%
==========================================
Files 166 167 +1
Lines 12717 12750 +33
Branches 536 531 -5
==========================================
+ Hits 11137 11168 +31
- Misses 1580 1582 +2
|
|
We decided to simply drop zlib instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for lightning/bolts#825
This lets us specify which compression algorithms we support and use one that our peer supports as well when syncing the network graph.