Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networks to init message #1254

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Add networks to init message #1254

merged 4 commits into from
Jan 21, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Dec 13, 2019

Implement lightning/bolts#682

This is a good opportunity to setup the infrastructure for a TLV stream in the Init message, which we can leverage for optional, un-speced features.

@t-bast t-bast force-pushed the networks-init-message branch 2 times, most recently from 4bffe45 to 2e9c752 Compare December 20, 2019 14:22
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #1254 into master will increase coverage by 0.5%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1254     +/-   ##
=========================================
+ Coverage      77%   77.51%   +0.5%     
=========================================
  Files         142      143      +1     
  Lines        9902    10126    +224     
  Branches      389      431     +42     
=========================================
+ Hits         7625     7849    +224     
  Misses       2277     2277
Impacted Files Coverage Δ
.../fr/acinq/eclair/wire/LightningMessageCodecs.scala 100% <100%> (ø) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 76.3% <100%> (+0.56%) ⬆️
...a/fr/acinq/eclair/wire/LightningMessageTypes.scala 86.36% <100%> (+0.64%) ⬆️
...src/main/scala/fr/acinq/eclair/wire/TlvTypes.scala 100% <100%> (ø) ⬆️
.../src/main/scala/fr/acinq/eclair/wire/InitTlv.scala 100% <100%> (ø)
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 51.12% <0%> (-0.6%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.65% <0%> (ø) ⬆️
...rc/main/scala/fr/acinq/eclair/ShortChannelId.scala 100% <0%> (ø) ⬆️
... and 3 more

@t-bast t-bast force-pushed the networks-init-message branch from 2e9c752 to efc450b Compare January 9, 2020 17:03
@t-bast t-bast marked this pull request as ready for review January 9, 2020 17:11
@t-bast t-bast changed the title Add Init TLV codecs Add networks to init message Jan 13, 2020
And receive other peer's network, disconnect if incompatible.
@t-bast t-bast force-pushed the networks-init-message branch from efc450b to 5c5ea0d Compare January 13, 2020 15:41
@pm47 pm47 self-requested a review January 14, 2020 15:03
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love our tlv implementation and the tests are so easy to write. A few minor comments.

@t-bast t-bast merged commit ca713ba into master Jan 21, 2020
@t-bast t-bast deleted the networks-init-message branch January 21, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants