-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networks to init message #1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
networks-init-message
branch
2 times, most recently
from
December 20, 2019 14:22
4bffe45
to
2e9c752
Compare
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
=========================================
+ Coverage 77% 77.51% +0.5%
=========================================
Files 142 143 +1
Lines 9902 10126 +224
Branches 389 431 +42
=========================================
+ Hits 7625 7849 +224
Misses 2277 2277
|
t-bast
force-pushed
the
networks-init-message
branch
from
January 9, 2020 17:03
2e9c752
to
efc450b
Compare
And receive other peer's network, disconnect if incompatible.
t-bast
force-pushed
the
networks-init-message
branch
from
January 13, 2020 15:41
efc450b
to
5c5ea0d
Compare
pm47
reviewed
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, love our tlv implementation and the tests are so easy to write. A few minor comments.
eclair-core/src/main/scala/fr/acinq/eclair/wire/LightningMessageTypes.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/wire/LightningMessageCodecsSpec.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Jan 21, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement lightning/bolts#682
This is a good opportunity to setup the infrastructure for a TLV stream in the Init message, which we can leverage for optional, un-speced features.