You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We weren't correctly closing SQL statements when comparing DBs and
migrating them. All the DB handlers for normal operation (read/write
channels, payments, etc) are already correctly closed after execution.
Fixes#2425
We weren't correctly closing SQL statements when comparing DBs and
migrating them. All the DB handlers for normal operation (read/write
channels, payments, etc) are already correctly closed after execution.
Fixes#2425
I went through the code and to my surpise you don't close any Statement or ResultSet after use.
Afaik this is bad practice and can lead to degraded DB performance and resource leakes (if combined with bad JDBCD driver)
Simple example from: CompareDb.scala
A close() statement after the while(rs.next()) loop would immediately free up the resources
The text was updated successfully, but these errors were encountered: