-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff linter #537
Ruff linter #537
Conversation
Hey @CompRhys, looking at your changes, some of them will break compatibility with Python version 3.7 and 3.8. |
I ran with |
I think these kind of type hints: str | Path | None are not supported with older python versions. Why do you want to change the way we do type hints? |
they are actually, if you add |
Good to know. Is there any guidelines from Python to prefere these kind of annotations? |
The pep for it was https://peps.python.org/pep-0604/ generally I think the preference has been to move towards not needing to explicitly import anything in order to type hint standard types such as list, str or combinations thereof. |
yes, |
a02eacc
to
60f207d
Compare
closing as it seems that there's no interest from maintainers |
Addresses #534. Much faster linting and formatting using 1 tool as opposed to 3.