-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on-the-fly checkpoint download and caching in mace_mp
#230
Merged
ilyes319
merged 15 commits into
ACEsuit:develop
from
janosh:fix-hardcoded-mace-mp-dtype
Nov 17, 2023
Merged
Add on-the-fly checkpoint download and caching in mace_mp
#230
ilyes319
merged 15 commits into
ACEsuit:develop
from
janosh:fix-hardcoded-mace-mp-dtype
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
changed the title
Fix hardcoded
Add on-the-fly checkpoint download and caching in Nov 16, 2023
default_dtype = "float32"
in mace_mp
mace_mp
fixes RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False.
…iversal.model shipped with repo
…raise better err when that fails and add special values 'medium', 'large' for model_path
janosh
added a commit
to materialsproject/atomate2
that referenced
this pull request
Nov 20, 2023
…mace#230 and silence deprecation warning
janosh
added a commit
to materialsproject/atomate2
that referenced
this pull request
Nov 20, 2023
…model (#614) * MACE Static/RelaxMakers default to loading mace_mp instead of test model * parametrize model_path in test_mace_static_maker and test_mace_relax_maker * bump matgl==0.9.0 to fix CI error * del revert_torch_default_dtype fixture used in mace tests * mace_mp() pass model_path as model to adapt new API added in ACEsuit/mace#230 and silence deprecation warning * tmp uncomment failing asserts in test_elastic_wf_with_m3gnet * update test_mace_static_maker and test_mace_relax_maker: model_path->model * use MACE develop branch with latest mace_mp fixes * use MACE develop branch even in strict deps (ouch...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.