Multi-Target GitHub Releases #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…general metadata artifact glob
…loy-2-start.yml` invocation
CodeGat
added
type:feature
CodeGat
force-pushed
the
200-multi-target-release
branch
from
660cccc to
de70856
Compare
tmcadam
reviewed
Jan 9, 2025
tmcadam
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #200, supports #121
Background
This PR updates our release pipeline to do a single, post-multi-target-deployment GitHub Release, of the form #200 (comment) - instead of a release per deployment target. See image for a rough idea of the changes:
In this PR:
releaseandbuild-dbjobs out of matrixeddeploy-2-start.ymljob, intocd.yml, so it can fire once all deployments are completespack.yaml,spack.lock...) to instead be prepended with deployment target (eg.deploy-metadata.Gadi,deploy-metadata.Setonix...)deploy-2-start.yml, similar to thedeploy-outputs.*glob from matrixeddeploy-1-setup.yml(eg.deploy-metadata.*). Used to add deployment metadata files to the release.Testing
Testing of the new release comment generation was done in my own test org so we don't create any actual release deployments of
ACCESS-TEST. This workflow run created https://github.com/codegat-test-org/test/releases/tag/v1.0.0 using this workflow file.