getting_started/spack.md: incorporate feedback #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
harshula
force-pushed
the
harshula/set-up-spack-feedback
branch
5 times, most recently
from
2c41854 to
5c36fb8
Compare
atteggiani
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thank you for this PR @harshula.
Overall I like the updates.
There are a couple of things I would change and a few missing coloured outputs (see comments).
I am happy to work on the suggestions/coloured outputs if it's ok for you.
harshula
force-pushed
the
harshula/set-up-spack-feedback
branch
from
dd6b6ea to
1e73f67
Compare
blimlim
reviewed
Oct 15, 2024
harshula
force-pushed
the
harshula/set-up-spack-feedback
branch
2 times, most recently
from
dfad5a2 to
51df1a8
Compare
atteggiani
requested review from
atteggiani
and removed request for
atteggiani
atteggiani
approved these changes
Oct 17, 2024
atteggiani
requested review from
atteggiani
and removed request for
atteggiani
|
Addressed all comments. |
blimlim
approved these changes
Oct 17, 2024
|
Hi @atteggiani , Looks good. One problem is the |
Fixed the compiler version. |
Squashed 10 commits: getting_started/spack.md: incorporate feedback * Thanks to Claire Carouge, Chris Bull and Davide Marchegiani. Changed '/home/565/davide' with '/Users/davide' in 'how to build a model' page Moved CSS styles to 'access-nri.css'. Minor fixes in the styles for 'how to build a model'. Added coloured outputs Fix colours for spack output Added Spencer's suggestions Added specification of step not require in admonition of 'how to build a mode' page Added Spencer's suggestion on liinking the 'how to run a model page' Fixed compiler in install output Fixed /Users/davide. Fixed architecture.
atteggiani
force-pushed
the
harshula/set-up-spack-feedback
branch
from
0c7434c to
ae2384b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.