Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ingest due ASF_Search Updates #83

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Fix Ingest due ASF_Search Updates #83

merged 11 commits into from
Dec 7, 2022

Conversation

cmarshak
Copy link
Collaborator

@cmarshak cmarshak commented Dec 7, 2022

Resolves #79 for production.

The latest merge into dev modifies the output json and is validated correctly as can be seen below.

import json
import jsonschema
import requests

resp_json = requests.get('https://hyp3-a19-jpl-contentbucket-1wfnatpznlg8b.s3.us-west-2.amazonaws.com/a6bdf7a4-7dc6-472c-bebf-3b1c10ac82ff/S1-GUNW-D-R-044-tops-20210925_20200930-172127-00169W_00053N-PP-812d-v2_0_6.json').json()

with open('schema.json') as f:
    schema = json.load(f)

jsonschema.validate(instance=resp_json, schema=schema)

@cmarshak cmarshak added the patch Bump the patch version number of this project label Dec 7, 2022
@cmarshak
Copy link
Collaborator Author

cmarshak commented Dec 7, 2022

I am never sure if we have to modify the changelog at this point because of two merges into dev or we can keep it as such.

I am happy if I just manually modify release to 0.2.1. Let me know.

CHANGELOG.md Outdated Show resolved Hide resolved
@cmarshak
Copy link
Collaborator Author

cmarshak commented Dec 7, 2022

I just changed it directly - honestly if this is the hardest thing - I can get the hang of it!

Still actions are super efficient IMHO.

@cmarshak cmarshak marked this pull request as ready for review December 7, 2022 22:26
@cmarshak cmarshak enabled auto-merge December 7, 2022 22:26
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@cmarshak cmarshak merged commit 6cfca41 into main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bump the patch version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants