Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation #92

Merged
merged 13 commits into from
Sep 24, 2020
Merged

Annotation #92

merged 13 commits into from
Sep 24, 2020

Conversation

s-fong
Copy link
Contributor

@s-fong s-fong commented Sep 17, 2020

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes as noted. I'll review the face annotations later.

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/annotation/stellate_terms.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to comments in code.
I think the generic shape with 'default' parameters should have a generic annotation group 'stellate', not 'cervicothoracic ganglion'.
I'm thinking it would make sense to change parameter set 'Mouse 1' to be 'Mouse cervicothoracic ganglion 1', and make the group of that name for that case?

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
@s-fong
Copy link
Contributor Author

s-fong commented Sep 23, 2020

I am not changing the term 'cervicothoracic ganglion' to 'stellate'. 'Stellate' is unscientific and is more of a nickname, so I'm leaving the names as is.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pretty minor pair of fixes now then it's in this morning.

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
@rchristie rchristie merged commit c0ecb19 into ABI-Software:master Sep 24, 2020
@s-fong s-fong deleted the annotation branch September 24, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants