Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellate #89

Merged
merged 22 commits into from
Sep 7, 2020
Merged

Stellate #89

merged 22 commits into from
Sep 7, 2020

Conversation

s-fong
Copy link
Contributor

@s-fong s-fong commented Sep 2, 2020

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes needed.
I'm also interested in the node at the end of the arm being a reduced distance from the next node so that final element length is 0.5*(elementLength + elementWidth) and d1 is magnitude elementWidth i.e. matching d2 around the whole outside (which is elegant). Maybe later. That would mean d2 wouldn't have to be so large here.

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fairly minor fixes now - see inline notes (which I put on the 2nd last commit if not easy to find).
Can you also please remove fieldmodule beginChange() and endChange() calls from generateBaseMesh(). I no longer want these forms used and the replacement ChangeManager(fieldmodule) should already be done by the code calling this.

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@rchristie rchristie merged commit c2fb001 into ABI-Software:master Sep 7, 2020
@s-fong s-fong deleted the stellate branch September 7, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants