-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellate #89
Stellate #89
Conversation
…on a function for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some fixes needed.
I'm also interested in the node at the end of the arm being a reduced distance from the next node so that final element length is 0.5*(elementLength + elementWidth) and d1 is magnitude elementWidth i.e. matching d2 around the whole outside (which is elegant). Maybe later. That would mean d2 wouldn't have to be so large here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some fairly minor fixes now - see inline notes (which I put on the 2nd last commit if not easy to find).
Can you also please remove fieldmodule beginChange() and endChange() calls from generateBaseMesh(). I no longer want these forms used and the replacement ChangeManager(fieldmodule) should already be done by the code calling this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
No description provided.