Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heart ventricles 3 and arterial valves #81

Merged
merged 29 commits into from
Jul 23, 2020
Merged

Heart ventricles 3 and arterial valves #81

merged 29 commits into from
Jul 23, 2020

Conversation

rchristie
Copy link
Member

Work in progress.

@rchristie
Add arterial valve scaffold
3b98304
@rchristie
Add valve centre and rotation parameters
9186da9
@rchristie
Add d3 to valve inlet, normal to axis
fe8d417
@rchristie
Add transformation to heart arterial valve.
e00f43f
@rchristie
Add heart ventricles 3
e623212
@rchristie
Implement RV inlet/outlet angles
4a45599
@rchristie
Fix curve sampling error for looped tracksurface
6d2946c
@rchristie
Improve RV free wall base curve
9ab9632
@rchristie
Add part of LV free wall
b4dd3e2
@rchristie
Add ShieldMesh and LV free wall elements
19cbb6e
@rchristie
Space elements around interventricular sulcus better
e83d0de
@rchristie
Use common code for triple points on shield mesh
5a55136
@rchristie
Fix inner derivatives
76ab519
@rchristie
Fix LV apex curve derivatives, refinement
1efd810
@rchristie
Complete LV with elements up LV apex
a768865
@rchristie
Use more logical shield mesh layout
5d4791a
@rchristie
Add interventricular sulcus elements
d74f275
@rchristie
Tweak ventricles 3 shape
1dd4faa
@rchristie
Merge remote-tracking branch 'abi/master' into base
e53f8cc
@rchristie
Merge branch 'fiducial' into base
12b2e49
@rchristie
Fix ventricles3 annotations, add apex marker
51deab9
@rchristie
Merge branch 'master' into base
7e7af23
@rchristie
Merge remote-tracking branch 'abi/master' into base
be33d52
@rchristie
Merge remote-tracking branch 'abi/master' into base
4b3189c
@rchristie
Improve heart test, fix coordinate range
2259858
@rchristie
Fix modulo bug for numbers of elements
5b33d37
mlin865
mlin865 suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go with some minor updates.

src/scaffoldmaker/meshtypes/meshtype_3d_heartventricles3.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/tracksurface.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/shieldmesh.py Outdated Show resolved Hide resolved
mlin865
mlin865 reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes. Just make sure the condition is correct for the part I commented on and it's good to go.

src/scaffoldmaker/meshtypes/meshtype_3d_heartventricles2.py Show resolved Hide resolved
@rchristie rchristie merged commit b0247b2 into ABI-Software:master Jul 23, 2020
@rchristie rchristie deleted the base branch July 23, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlin865 mlin865 mlin865 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchristie @mlin865