Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformations in ScaffoldPackage #71

Merged
merged 5 commits into from
May 4, 2020
Merged

Transformations in ScaffoldPackage #71

merged 5 commits into from
May 4, 2020

Conversation

rchristie
Copy link
Member

No description provided.

mahyar-osn
mahyar-osn approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just one small comment and one question.

src/scaffoldmaker/scaffoldpackage.py Outdated Show resolved Hide resolved
src/scaffoldmaker/scaffoldpackage.py Show resolved Hide resolved
@rchristie rchristie merged commit cf52829 into ABI-Software:master May 4, 2020
@rchristie rchristie deleted the transform branch May 27, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahyar-osn mahyar-osn mahyar-osn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchristie @mahyar-osn